[Linux-HA] pgsql OCF resource agent and other questions

[Andrew Beekhof]

On Feb 12, 2008, at 8:57 PM, Zoltan Boszormenyi wrote:

> Andrew Beekhof írta:
>>
>> On Feb 12, 2008, at 4:59 PM, Zoltan Boszormenyi wrote:
>>
>>> Hi,
>>>
>>> Serge Dubrouski írta:
>>>> pgsql OCF RA doesn't support multistate configuration so I don't  
>>>> think
>>>> that creating a clone would be a good idea.
>>>>
>>>
>>> Thanks for the information.
>>>
>>> Some other questions.
>>>
>>> According to http://linux-ha.org/v2/faq/resource_too_active
>>> the monitor action should return 0 for running, 7 ($OCF_NOT_RUNNING)
>>> for downed resources and anything else for failed ones.
>>> Either this documentation is buggy,
>>
>> no
>>
>>> or heartbeat doesn't conform to its own docs.
>>
>> also no
>>
>>>
>>> Here's the scenario: londiste creates a pidfile and deletes it  
>>> when it quits correctly.
>>> However, if I kill it manually then the pidfile stays. What should  
>>> my script return
>>> when it detects that the process with the indicated PID is no  
>>> longer there?
>>> It's not a "downed" resource, it's a failed one. So I returned  
>>> $OCF_ERR_GENERIC.
>>> But after some time heartbeat says that my resource became  
>>> "unmanaged".
>>
>> i'm guessing (because you've not included anything on which to  
>> comment properly) that the stop action failed
>
> It shouldn't have failed, stop action always returns $OCF_SUCCESS.
>
>>> In contrast to this, the pgsql OCF RA does it differently. It  
>>> always returns 7
>>> when it finds that there's no postmaster process. Which is the  
>>> right behaviour?
>>
>> it depends what you want to happen.
>> if you want a stop to be sent, use OCF_ERR_GENERIC.
>> if the resource is stateless and doesnt need any cleaning up, use  
>> OCF_NOT_RUNNING
>
> It's quite an important detail. Shouldn't this be documented at
> http://linux-ha.org/OCFResourceAgent ?

yep.  but its a wiki so anyone can do that :)