[Linux-HA] New problem(s) with heartbeat 2.0.3 and STONITH

Sun Oct 30 11:29:31 MST 2005

Hello everybody,

On Fri, Oct 28, 2005 at 11:16:28PM -0600, Alan Robertson wrote:
> Peter Kruse wrote:
> > Hello,
> > 
> > Alan Robertson wrote:
> > 
> >> My guess is that op->node_name or op->optype is NULL.  The code should
> >> have validated those.  Since they're critical, and they come from
> >> who-knows-where (meaning some doofus user process), they should
> >> definitely have been error checked, and there should be a clear
> >> message about their errors.
> >>
> > I'm sorry, but I don't understand any of this.  Does that mean you know the
> > cause of this error, or just that the error message has no meaning?
> 
> It means I was reading the code, and got a clue from it, and was in 
> effect hinting to the author or that code to look at it in more detail.
> 
>  From emails that were sent, it appears that he got the hint and looked 
> at it.  From looking at the CVS logs, it looks like a patch was checked 
> in for this problem.
>
Yes, I just tried the current cvs version and it works. (Problem 2 (the "cannot add field to ha_msg" Error) is gone and Problem 1 seems to be solved either)

Many thanks to all who fixed the Problems.

Best regards,
Stefan Peinkofer
> Exactly what the cause was (from your perspective), I'm not sure.
> 
> -- 
>      Alan Robertson <alanr at unix.sh>
> 
> "Openness is the foundation and preservative of friendship...  Let me 
> claim from you at all times your undisguised opinions." - William 
> Wilberforce

> X-Account-Key: account1
> Return-Path: <linux-ha-cvs-bounces at lists.linux-ha.org>
> Delivered-To: spamcop-net-alanr at spamcop.net
> Received: (qmail 23876 invoked from network); 29 Oct 2005 03:31:33 -0000
> X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on blade4
> X-Spam-Level: 
> X-Spam-Status: hits=0.6 tests=AWL,NO_REAL_NAME version=3.1.0
> Received: from unknown (192.168.1.103)
> 	by blade4.cesmail.net with QMQP; 29 Oct 2005 03:31:33 -0000
> Received: from mail.maclawran.ca (HELO demo.bb4.com) (65.39.147.83)
> 	by mx53.cesmail.net with SMTP; 29 Oct 2005 03:31:33 -0000
> Received: from new.community.tummy.com (postfix at newcommunity.tummy.com
> 	[198.49.126.209])
> 	by demo.bb4.com (8.13.0/8.13.0) with ESMTP id j9T3QTte074372;
> 	Fri, 28 Oct 2005 23:26:29 -0400 (EDT)
> Received: from newcommunity.tummy.com (localhost [127.0.0.1])
> 	by new.community.tummy.com (Postfix) with ESMTP id D5B1F20347C2;
> 	Fri, 28 Oct 2005 21:31:31 -0600 (MDT)
> X-Original-To: linux-ha-cvs at lists.community.tummy.com
> Delivered-To: mailman+post-linux-ha-cvs at newcommunity.tummy.com
> Received: by new.community.tummy.com (Postfix, from userid 547)
> 	id 5DD442034025; Fri, 28 Oct 2005 21:31:30 -0600 (MDT)
> To: linux-ha-cvs at lists.community.tummy.com
> Message-Id: <20051029033130.5DD442034025 at new.community.tummy.com>
> Date: Fri, 28 Oct 2005 21:31:30 -0600 (MDT)
> From: linux-ha-cvs at lists.linux-ha.org
> Subject: [Linux-ha-cvs] Linux-HA CVS: lib by sunjd from 
> X-BeenThere: linux-ha-cvs at lists.linux-ha.org
> X-Mailman-Version: 2.1.5
> Precedence: list
> Reply-To: linux-ha-dev at lists.linux-ha.org
> List-Id: Linux-HA CVS commits <linux-ha-cvs.lists.linux-ha.org>
> List-Unsubscribe: <http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs>,
> 	<mailto:linux-ha-cvs-request at lists.linux-ha.org?subject=unsubscribe>
> List-Post: <mailto:linux-ha-cvs at lists.linux-ha.org>
> List-Help: <mailto:linux-ha-cvs-request at lists.linux-ha.org?subject=help>
> List-Subscribe: <http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs>,
> 	<mailto:linux-ha-cvs-request at lists.linux-ha.org?subject=subscribe>
> Sender: linux-ha-cvs-bounces at lists.linux-ha.org
> Errors-To: linux-ha-cvs-bounces at lists.linux-ha.org
> X-DCC-Misty-Metrics: demo.bb4.com 1170; Body=2 Fuz1=2 Fuz2=2
> X-SpamCop-Checked: 192.168.1.103 65.39.147.83 198.49.126.209 127.0.0.1 
> 
> linux-ha CVS committal
> 
> Author  : sunjd
> Host    : 
> Project : linux-ha
> Module  : lib
> 
> Dir     : linux-ha/lib/fencing
> 
> 
> Modified Files:
> 	stonithd_lib.c 
> 
> 
> Log Message:
> permit private_data be null
> ===================================================================
> RCS file: /home/cvs/linux-ha/linux-ha/lib/fencing/stonithd_lib.c,v
> retrieving revision 1.18
> retrieving revision 1.19
> diff -u -3 -r1.18 -r1.19
> --- stonithd_lib.c	24 Oct 2005 14:57:44 -0000	1.18
> +++ stonithd_lib.c	29 Oct 2005 03:31:29 -0000	1.19
> @@ -283,8 +283,6 @@
>  	    ||(ha_msg_add(request, F_STONITHD_NODE, op->node_name ) != HA_OK)
>  	    ||(op->node_uuid == NULL
>  	       || ha_msg_add(request, F_STONITHD_NODE_UUID, op->node_uuid) != HA_OK)
> -	    ||(op->private_data == NULL
> -	       || ha_msg_add(request, F_STONITHD_PDATA, op->private_data) != HA_OK)
>  	    ||(ha_msg_add_int(request, F_STONITHD_TIMEOUT, op->timeout) 
>  		!= HA_OK) ) {
>  		stdlib_log(LOG_ERR, "stonithd_node_fence: "
> @@ -292,6 +290,14 @@
>  		ZAPMSG(request);
>  		return ST_FAIL;
>  	}
> +	if  (op->private_data != NULL) {
> +	       if ( ha_msg_add(request, F_STONITHD_PDATA, op->private_data) != HA_OK) {
> +			stdlib_log(LOG_ERR, "stonithd_node_fence: "
> +			   "Failed to add F_STONITHD_PDATA field to ha_msg.");
> +			ZAPMSG(request);
> +			return ST_FAIL;
> +		}
> +	}
>  
>  	/* Send the stonith request message */
>  	if (msg2ipcchan(request, chan) != HA_OK) {
> 
> 
> _______________________________________________
> Linux-ha-cvs mailing list
> Linux-ha-cvs at lists.linux-ha.org
> http://lists.community.tummy.com/mailman/listinfo/linux-ha-cvs
> 

> _______________________________________________
> Linux-HA mailing list
> Linux-HA at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha
> See also: http://linux-ha.org/ReportingProblems