[Linux-ha-dev] Re: Various SNMP subagent fixes

Horms horms at verge.net.au
Tue Aug 23 20:28:46 MDT 2005


Sorry, I forgot one, the attached fix resolves some signedness isses
that are flagged by gcc-4.0


-- 
Horms
-------------- next part --------------
Index: snmp_subagent/LHAResourceGroupTable.c
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/snmp_subagent/LHAResourceGroupTable.c,v
retrieving revision 1.3.2.2
diff -u -r1.3.2.2 LHAResourceGroupTable.c
--- a/snmp_subagent/LHAResourceGroupTable.c	27 Oct 2004 23:20:12 -0000	1.3.2.2
+++ b/snmp_subagent/LHAResourceGroupTable.c	24 Aug 2005 02:02:17 -0000
@@ -168,7 +168,7 @@
     static size_t i = 0;
     netsnmp_variable_list *vptr;
     struct hb_rsinfo * info;
-    int status;
+    uint32_t status;
 
     if (*my_loop_context != NULL) {
 	i = *((size_t *) *my_loop_context);
Index: include/saf/ais_base.h
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/include/saf/ais_base.h,v
retrieving revision 1.3.2.4
diff -u -r1.3.2.4 ais_base.h
--- a/include/saf/ais_base.h	16 Nov 2004 02:40:11 -0000	1.3.2.4
+++ b/include/saf/ais_base.h	24 Aug 2005 02:02:17 -0000
@@ -69,7 +69,7 @@
 
 typedef struct {
     SaUint16T length;
-    unsigned char value[SA_MAX_NAME_LENGTH];
+    char value[SA_MAX_NAME_LENGTH];
 } SaNameT;
 
 typedef struct {
Index: include/saf/ais_membership.h
===================================================================
RCS file: /home/cvs/linux-ha/linux-ha/include/saf/ais_membership.h,v
retrieving revision 1.1.2.2
diff -u -r1.1.2.2 ais_membership.h
--- a/include/saf/ais_membership.h	28 Oct 2004 22:02:57 -0000	1.1.2.2
+++ b/include/saf/ais_membership.h	24 Aug 2005 02:02:17 -0000
@@ -14,7 +14,7 @@
 #define SA_CLM_MAX_ADDRESS_LENGTH 64
 typedef struct {
     SaUint8T length;
-    unsigned char value[SA_CLM_MAX_ADDRESS_LENGTH];
+    char value[SA_CLM_MAX_ADDRESS_LENGTH];
 } SaClmNodeAddressT;
 
 typedef struct {


More information about the Linux-HA-Dev mailing list